-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update packages to make publish smaller #49
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 10 10
Lines 173 173
Branches 35 35
=======================================
Hits 167 167
Misses 5 5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jason and I were just talking about this! Thanks for doing this work. I had one comment but it's non-blocking
I just realized that I do not have permission to merge this pr. @jsnwesson can you merge after review it? |
Hey @leangseu-edx ! Thanks for looking into this, although I noticed that when I tried running the "host" example app, it wasn't able to render the plugins. Having compared it to the |
268cd60
to
273569c
Compare
I found the issue. It seems like
are required at the root of the project. I don't know why it seems necessary. Additional file changed are just replacing |
ebfdbf3
to
8348592
Compare
Sorry to add more stuff to this pr. I just feel like it would help with future development. I updated the |
8348592
to
97554eb
Compare
@leangseu-edx no apologies needed, this is all greatly appreciated given the time you've put into making the experience cleaner! To make sure the terms are clear:
Oddly enough, I was able to see the Host MFE by going to |
8d9de67
to
c9b8fa3
Compare
I was sure I changed that back yesterday. At first I thought Anyway, now it should changed accordingly. |
Sweeet thanks for the fix! Approved and greatly appreciated. Thanks again @leangseu-edx ! |
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@edx/frontend-plugin-framework
with@openedx/frontend-plugin-framework
npm start
ornpm run build
npm run start:example